Skip to content

[Woo POS][Barcodes] Copy, Localization, and UI adjustments #15948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jul 26, 2025
Merged

[Woo POS][Barcodes] Copy, Localization, and UI adjustments #15948

merged 27 commits into from
Jul 26, 2025

Conversation

@staskus
Copy link
Contributor

@staskus staskus commented Jul 24, 2025 •
edited
Loading

Description

WOOMOB-792
WOOMOB-867
WOOMOB-876

I used this task to do codebase and UI cleanup:

  • Review and tweak copy
  • Apply localization to unlocalized strings
  • Review Figma designs to adjust colors, sizing, and padding where needed

Steps to reproduce

Do a general overview of setup view strings, sizing, and colors. No functionality should be changed. Compare with Figma 1du9lOyPaHTXg2WVwZjZjH-fi-2231_5674

Testing information

Tested on iPadOS 18.5 simulator and iPadOS 26 device

Screenshots

Simulator.Screen.Recording.-.iPad.Pro.11-inch.M4.-.2025-07-24.at.23.57.40.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

staskus added 22 commits July 24, 2025 16:31
@staskus
Convert scannerSetUpBarcodeStepTitleFormat to NSLocalizedString
da74e8f
@staskus
Convert setUpBarcodeHIDStepInstruction to NSLocalizedString
e464d39
@staskus
Convert setUpBarcodePairStepInstruction to NSLocalizedString
9cafff4
@staskus
Convert informationButtonTitle to NSLocalizedString
e661d62
@staskus
Convert setup selection view strings to NSLocalizedString
8f95199
@staskus
Convert pairing view strings to NSLocalizedString
c1beaa4
@staskus
Convert test scanner strings to NSLocalizedString
b50bf3f
@staskus
Convert setup complete strings to NSLocalizedString
be97f3b
@staskus
Convert error view strings to NSLocalizedString
34e9cd9
@staskus
Update HID setup instruction text
bd4cdbb
@staskus
Update pairing setup instruction text
223b378
@staskus
Add missing full stop to test scanner instruction
97f67c4
@staskus
Update error instruction text formatting
097d17b
@staskus
Fix grammar: setup/set up usage consistency
64f8a1c
@staskus
Correct complete title to past participle form
6165041
@staskus
Update pairing instruction with feedback indicators
cbac2bd
@staskus
Update settings button text and style
0885b8c
@staskus
Update pairing view text and button colors
2380669
@staskus
Remove TODO comment from PointOfSaleAssets
c1c9c3c
@staskus
Merge branch 'trunk' into woomob-876-woo-posbarcodes-copy-updates-for…
4a6ae66 
…-the-setup-flow
@staskus
Make Scanner setup lowercased
8b87415
@staskus
Adjust padding and sizing for setup views
4c7fd45
@staskus staskus marked this pull request as draft July 24, 2025 20:32
@staskus staskus changed the title [Woo POS][Barcodes] Updat [Woo POS][Barcodes] Copy, Localization, and UI adjustments Jul 24, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 24, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr15948-0e51750
Version22.9
Bundle IDcom.automattic.alpha.woocommerce
Commit0e51750
Installation URL48831dlpc1f3g
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@staskus staskus added type: task An internally driven task. feature: POS labels Jul 24, 2025
@staskus staskus added this to the 22.9 milestone Jul 24, 2025
@staskus staskus requested a review from jaclync July 24, 2025 20:58
@staskus staskus marked this pull request as ready for review July 24, 2025 20:58
@wpmobilebot wpmobilebot modified the milestones: 22.9, 23.0 Jul 25, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jul 25, 2025

Version 22.9 has now entered code-freeze, so the milestone of this PR has been updated to 23.0.

jaclync
jaclync approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

For this screen, does it make sense to mention "... in the device Bluetooth settings"? In iOS, it requires a tap to go to the Bluetooth settings as the link opens the app settings.

Simulator Screenshot - iPad Air 13-inch (M3) - 2025-07-25 at 13 56 25

WooCommerce/Classes/POS/Presentation/Barcode Scanner Setup/PointOfSaleBarcodeScannerSetup.swift Outdated
Comment on lines 136 to 144
@available(iOS 17.0, *)
#Preview("Scanner Setup - Large Screen") {
PointOfSaleBarcodeScannerSetup(isPresented: .constant(true))
}

@available(iOS 17.0, *)
#Preview("Scanner Setup - Compact") {
PointOfSaleBarcodeScannerSetup(isPresented: .constant(true))
}
Copy link
Contributor

@jaclync jaclync Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: how are these two previews different, maybe some modifier is missing? 🤔

...erce/Classes/POS/Presentation/Barcode Scanner Setup/PointOfSaleBarcodeScannerSetupFlow.swift
)

//TODO: WOOMOB-792
static let scannerSetUpBarcodeStepTitleFormat = "Scanner Setup"
Copy link
Contributor

@jaclync jaclync Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing "Scanner set up" in the title, when selecting "Other" from the first page:

Simulator Screenshot - iPad Air 13-inch (M3) - 2025-07-25 at 13 45 49

It looks like there are still 2 unlocalized strings in PointOfSaleBarcodeScannerInformationModal.swift used in BarcodeScannerInformation and ProductBarcodeSetupInformation.

Copy link
Contributor Author

@staskus staskus Jul 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed them! 👍

@staskus staskus enabled auto-merge July 26, 2025 16:44
@staskus staskus merged commit c9c8b48 into trunk Jul 26, 2025
13 checks passed
@staskus staskus deleted the woomob-876-woo-posbarcodes-copy-updates-for-the-setup-flow branch July 26, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaclync jaclync jaclync approved these changes

Assignees

No one assigned

Labels

feature: POS type: task An internally driven task.

Projects

None yet

Milestone

23.0

Development

Successfully merging this pull request may close these issues.

4 participants

@staskus @wpmobilebot @jaclync